Skip to content

Conversation

@OwenCoogan
Copy link
Contributor

@OwenCoogan OwenCoogan commented Jan 28, 2026

What does this PR do?

  • Added @haserror boolean prop to explicitly control error state
  • When hasError is true, the textarea shows a danger-500 border via the oss-textarea--errored class

- Backward compatibility (fallback behavior):

  • Existing code using @errorMessage continues to work without changes
  • If @haserror is not provided but @errorMessage exists (truthy), error state is shown
  • Empty string @errorMessage does not trigger error state (only truthy values)
  • Both props can be used together

- Migration:

  • No immediate changes required — existing implementations continues to work
  • New code can use @haserror directly for adding the border only
  • Gradual migration is supported — components can use either prop or both

Related to: #

What are the observable changes?

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@OwenCoogan OwenCoogan self-assigned this Jan 28, 2026
@linear
Copy link

linear bot commented Jan 28, 2026

@OwenCoogan OwenCoogan changed the base branch from master to feature/bulk-action-workflow January 28, 2026 13:36
@OwenCoogan OwenCoogan merged commit bf4506f into feature/bulk-action-workflow Jan 28, 2026
3 checks passed
@OwenCoogan OwenCoogan deleted the oc/DRA-4481 branch January 28, 2026 13:47
@OwenCoogan OwenCoogan restored the oc/DRA-4481 branch January 28, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants