Add disableAutoActive option to OSS::Anchor #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/ready-to-merge
reviewed/needs-work
labels
upfluence-bot
added
reviewed/needs-review
reviewed/needs-work
and removed
reviewed/needs-work
reviewed/needs-review
labels
nathalieArnoux
approved these changes
Jan 27, 2026
OwenCoogan
approved these changes
Jan 28, 2026
Elodie-DeMatteis-Upf
merged commit 10da1b1
into
feature/improve-settings-navigation
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
OSS::Anchorcomponent is using EmberJSLinkTocomponent to render internal routes. Its default behavior is to add anactiveCSS class when theLinkToroute matches the current route. However, in some cases we may need to manage theactivestyling independently of the route.This PR adds a new
disableAutoActiveoptional arg to theOSS::Anchorcomponent that will, if true, prevent theLinkTofrom being automatically set in an "active" state.The solution is using
LinkTocurrent-whenargument, documented here.This new arg is propagated from the group items directly through the
OSS::Layout::Sidebar::Itemcomponent to theOSS::Anchorcomponent.Related to: #6694
What are the observable changes?
Upluence settings page: the active state is managed directly by the sidebar, not by Ember. Here, several items match the same route, but only the one with the current section is "active".
Upfluence Search page: corresponding sidebar item without
disableAutoActiveis correctly in an "active" state.Good PR checklist