-
Notifications
You must be signed in to change notification settings - Fork 0
Conditional enablement of 'Clear filters' button in Hypertable V2 #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phndiaye
reviewed
Sep 25, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just add a test for the global Reset filters button presence and we're good ^^ Also ask for a Draco review as this project is x-squad :)
tests/integration/components/hyper-table-v2/filtering-renderers/common/column-actions-test.ts
Outdated
Show resolved
Hide resolved
Elodie-DeMatteis-Upf
approved these changes
Sep 26, 2025
JulienVannier66
approved these changes
Sep 26, 2025
aprentout
reviewed
Sep 29, 2025
addon/components/hyper-table-v2/filtering-renderers/common/column-actions.hbs
Outdated
Show resolved
Hide resolved
aprentout
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
VEL-5021: Conditional enablement of filters' Clear filters button
VEL-5022: Conditional enablement of table's Reset Filters button
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes
Note
Show table-level Reset filters and per-column Clear filters only when filters/order exist; update column actions layout/skins, tests, and copy.
Reset filtersbutton only when any column hasfiltersororderviadisplayResetButtoninaddon/components/hyper-table-v2/index.{hbs,ts}.Clear filtersbutton only when the column hasfiltersororderviadisplayClearButton; change remove button@skintodefault; clear button@skintosecondary; adjust container/layout classes infiltering-renderers/common/column-actions.{hbs,ts}.tests/integration/components/hyper-table-v2*.hypertable.features.filtering.reset_all,hypertable.column.remove, andhypertable.column.clear_filtersintranslations/en-us.yaml.Written by Cursor Bugbot for commit b50b8ec. This will update automatically on new commits. Configure here.