Skip to content

Conversation

@olxmpe
Copy link
Contributor

@olxmpe olxmpe commented Sep 25, 2025

What does this PR do?

VEL-5021: Conditional enablement of filters' Clear filters button
VEL-5022: Conditional enablement of table's Reset Filters button

What are the observable changes?

Capture d’écran 2025-09-25 à 17 30 10 Capture d’écran 2025-09-25 à 17 29 58 Capture d’écran 2025-09-25 à 17 30 18

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes


Note

Show table-level Reset filters and per-column Clear filters only when filters/order exist; update column actions layout/skins, tests, and copy.

  • UI/Behavior:
    • Table header: Render Reset filters button only when any column has filters or order via displayResetButton in addon/components/hyper-table-v2/index.{hbs,ts}.
    • Column actions: Render Clear filters button only when the column has filters or order via displayClearButton; change remove button @skin to default; clear button @skin to secondary; adjust container/layout classes in filtering-renderers/common/column-actions.{hbs,ts}.
  • Tests:
    • Add/adjust integration tests to assert conditional visibility and correct handler invocations for reset/clear/remove in tests/integration/components/hyper-table-v2*.
  • i18n:
    • Tweak copy casing for hypertable.features.filtering.reset_all, hypertable.column.remove, and hypertable.column.clear_filters in translations/en-us.yaml.

Written by Cursor Bugbot for commit b50b8ec. This will update automatically on new commits. Configure here.

@olxmpe olxmpe self-assigned this Sep 25, 2025
@olxmpe olxmpe requested review from a team and phndiaye as code owners September 25, 2025 15:37
@olxmpe olxmpe requested review from aprentout and nathalieArnoux and removed request for a team September 25, 2025 15:37
@linear
Copy link

linear bot commented Sep 25, 2025

Copy link
Member

@phndiaye phndiaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add a test for the global Reset filters button presence and we're good ^^ Also ask for a Draco review as this project is x-squad :)

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@olxmpe olxmpe merged commit 93ca9c5 into master Sep 30, 2025
4 checks passed
@olxmpe olxmpe deleted the ol/vel-5021 branch September 30, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants