-
Notifications
You must be signed in to change notification settings - Fork 1
Updated: improve URL regex pattern recognition and added test cases #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
OwenCoogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gonna be a case of "I'm sure you got this" ![]()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
What does this PR do?
Updated URL regex to handle more cases, they can be checked in the updated tests.
The initial goal was to handle at least :
Good PR checklist
Note
Strengthens URL validation and significantly expands test coverage.
URL_REGEXthat supports optional protocol,www/non-wwwdomains, multi-level TLDs (e.g.,.co.uk), paths, queries, and fragments, while excluding IPs,localhost, ports, and non-http(s) schemesWritten by Cursor Bugbot for commit 03da261. This will update automatically on new commits. Configure here.