Update AWS XNetwork dependency to allow custom network configuration#30
Open
irizzant wants to merge 2 commits intoupbound:mainfrom
Open
Update AWS XNetwork dependency to allow custom network configuration#30irizzant wants to merge 2 commits intoupbound:mainfrom
irizzant wants to merge 2 commits intoupbound:mainfrom
Conversation
The network configuration parameters in the composition.yaml file have been updated to include the CIDR block and subnets for the network. This change ensures that the correct network configuration is used when the provider is AWS. Note: This commit message follows the established convention of using a prefix (feat) to indicate a new feature or enhancement.
Author
irizzant
changed the title
Author
Member
|
Hi @irizzant , sorry for the super long response. The project was migrated to new devex. Now it should be easier to propagate custom changes. Please check the new layout and please let us know if you are still interested in this feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR updates XNetwork to the latest version for AWS to use its network configuration capabilities.
Fixes #31
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
make e2e