Skip to content

Conversation

@ratafa
Copy link
Collaborator

@ratafa ratafa commented Sep 8, 2024

๐Ÿ”๏ธ ์ด PR์„ ํ†ตํ•ด ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

์–ด๋–ค ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ•œ๊ฑด์ง€, ์ด์Šˆ ๋Œ€์‘์ด๋ผ๋ฉด ์–ด๋–ค ์ด์Šˆ์ธ์ง€ PR์ด ์—ด๋ฆฌ๊ฒŒ ๋œ ๊ณ„๊ธฐ์™€ ๋ชฉ์ ์„ Reviewer ๋“ค์ด ์‰ฝ๊ฒŒ ์ดํ•ดํ•  ์ˆ˜ ์žˆ๋„๋ก ์ ์–ด ์ฃผ์„ธ์š”
์ผ๊ฐ ๋ฐฑ๋กœ๊ทธ ๋งํฌ๋‚˜ ๋‹ค์ด์–ด๊ทธ๋žจ, ํ”ผ๊ทธ๋งˆ, ์บก์ณ๋ฅผ ์ฒจ๋ถ€ํ•ด๋„ ์ข‹์•„์š”

  • identity ๋„๋ฉ”์ธ ๊ตฌํ˜„

โœจ ์ด PR์—์„œ ํ•ต์‹ฌ์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์€ ๋ฌด์—‡์ผ๊นŒ์š”?

๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์ฃผ์š”ํ•˜๊ฒŒ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ๋“ค์„ ์ ์–ด ์ฃผ์„ธ์š”

  • identity ๋„๋ฉ”์ธ์— ๋Œ€ํ•œ ์ „๋ฐ˜์ ์ธ ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • repository
    • dao
    • service
    • controller

๐Ÿ”– ํ•ต์‹ฌ ๋ณ€๊ฒฝ ์‚ฌํ•ญ ์™ธ์— ์ถ”๊ฐ€์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„์ด ์žˆ๋‚˜์š”?

์—†์œผ๋ฉด "์—†์Œ" ์ด๋ผ๊ณ  ๊ธฐ์žฌํ•ด ์ฃผ์„ธ์š”

  • ์—†์Œ

๐Ÿ™ Reviewer ๋ถ„๋“ค์ด ์ด๋Ÿฐ ๋ถ€๋ถ„์„ ์‹ ๊ฒฝ์จ์„œ ๋ด ์ฃผ์‹œ๋ฉด ์ข‹๊ฒ ์–ด์š”

๊ฐœ๋ฐœ ๊ณผ์ •์—์„œ ๋‹ค๋ฅธ ๋ถ„๋“ค์˜ ์˜๊ฒฌ์€ ์–ด๋– ํ•œ์ง€ ๊ถ๊ธˆํ–ˆ๊ฑฐ๋‚˜ ํฌ๋กœ์Šค ์ฒดํฌ๊ฐ€ ํ•„์š”ํ•˜๋‹ค๊ณ  ๋А๊ปด์ง„ ์ฝ”๋“œ๊ฐ€ ์žˆ๋‹ค๋ฉด ๋‚จ๊ฒจ์ฃผ์„ธ์š”

  • ์ด๊ฒŒ ์˜ฌ๋ฐ”๋ฅธ ๋ฐฉ์‹์ธ์ง€ ํ™•์‹คํ•˜์ง€ ์•Š๊ธฐ ๋•Œ๋ฌธ์— ํ”ผ๋“œ๋ฐฑ ๋งค์šฐ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์‹คํ–‰ ์‹œ, redis ๊ด€๋ จ ์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ํ•ด๋‹น ๋‚ด์šฉ์€ ๋งํฌ๋ฅผ ํ†ตํ•ด ํ™•์ธ ๋ถ€ํƒ๋“œ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค.

๐Ÿฉบ ์ด PR์—์„œ ํ…Œ์ŠคํŠธ ํ˜น์€ ๊ฒ€์ฆ์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์„๊นŒ์š”?

ํ…Œ์ŠคํŠธ๊ฐ€ ํ•„์š”ํ•œ ํ•ญ๋ชฉ์ด๋‚˜ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๊ฐ€ ์ถ”๊ฐ€๋˜์—ˆ๋‹ค๋ฉด ํ•จ๊ป˜ ์ ์–ด์ฃผ์„ธ์š”

  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ์„ ์•„์ง restdocs ์–‘์‹์— ๋งž๊ฒŒ ์ž‘์„ฑํ•˜์ง€ ๋ชปํ•œ ์  ์–‘ํ•ด ๋ถ€ํƒ๋“œ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค. ์ถ”ํ›„ ๋ณ€๊ฒฝํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

๐Ÿ“Œ PR ์ง„ํ–‰ ์‹œ ์ด๋Ÿฌํ•œ ์ ๋“ค์„ ์ฐธ๊ณ ํ•ด ์ฃผ์„ธ์š”

  • Reviewer ๋ถ„๋“ค์€ ์ฝ”๋“œ ๋ฆฌ๋ทฐ ์‹œ ์ข‹์€ ์ฝ”๋“œ์˜ ๋ฐฉํ–ฅ์„ ์ œ์‹œํ•˜๋˜, ์ฝ”๋“œ ์ˆ˜์ •์„ ๊ฐ•์ œํ•˜์ง€ ๋ง์•„ ์ฃผ์„ธ์š”.
  • Reviewer ๋ถ„๋“ค์€ ์ข‹์€ ์ฝ”๋“œ๋ฅผ ๋ฐœ๊ฒฌํ•œ ๊ฒฝ์šฐ, ์นญ์ฐฌ๊ณผ ๊ฒฉ๋ ค๋ฅผ ์•„๋ผ์ง€ ๋ง์•„ ์ฃผ์„ธ์š”.
  • Review๋Š” ํŠน์ˆ˜ํ•œ ์ผ€์ด์Šค๊ฐ€ ์•„๋‹ˆ๋ฉด Reviewer๋กœ ์ง€์ •๋œ ์‹œ์  ๊ธฐ์ค€์œผ๋กœ 3์ผ ์ด๋‚ด์— ์ง„ํ–‰ํ•ด ์ฃผ์„ธ์š”.
  • Comment ์ž‘์„ฑ ์‹œ Prefix๋กœ P1, P2, P3 ๋ฅผ ์ ์–ด ์ฃผ์‹œ๋ฉด Assignee๊ฐ€ ๋ณด๋‹ค ๋ช…ํ™•ํ•˜๊ฒŒ Comment์— ๋Œ€ํ•ด ๋Œ€์‘ํ•  ์ˆ˜ ์žˆ์–ด์š”
    • P1 : ๊ผญ ๋ฐ˜์˜ํ•ด ์ฃผ์„ธ์š” (Request Changes) - ์ด์Šˆ๊ฐ€ ๋ฐœ์ƒํ•˜๊ฑฐ๋‚˜ ์ทจ์•ฝ์ ์ด ๋ฐœ๊ฒฌ๋˜๋Š” ์ผ€์ด์Šค ๋“ฑ
    • P2 : ๋ฐ˜์˜์„ ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด ์ฃผ์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” (Comment)
    • P3 : ์ด๋Ÿฐ ๋ฐฉ๋ฒ•๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”~ ๋“ฑ์˜ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค (Chore)


๐Ÿ“ Assignee๋ฅผ ์œ„ํ•œ CheckList

  • ๋Œ€ํ‘œ ์‹ ๋ถ„ ์„ค์ • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
  • redis ์บ์‹œ ๊ธฐ๋Šฅ ์ถ”๊ฐ€

@ratafa ratafa requested a review from SangMinLeeAI September 8, 2024 10:16
@ratafa ratafa self-assigned this Sep 8, 2024
val identityList = identityRepository.findByUserId(userId);

// ์‹ ๋ถ„์˜ ๊ฐœ์ˆ˜๊ฐ€ 1๊ฐœ์ธ ๊ฒฝ์šฐ ์—…๋ฐ์ดํŠธ ๋กœ์ง์„ ์‹คํ–‰ํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.
if (identityList?.size == 1) return null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์‹ ๋ถ„์ด ํ•˜๋‚˜์ธ ๊ฒฝ์šฐ ์˜ˆ์™ธ๋ฅผ ๋˜์ง€๋Š” ๊ฒƒ๋„ ํ•˜๋‚˜์˜ ๋ฐฉ๋ฒ•์ด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Comment on lines +31 to +33
identityList?.forEach { identity: Identity ->
identityRepository.updateActiveIdentityList(identity.id, userId)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IdentityRepository ๋‚ด๋ถ€์— ๋Œ€ํ‘œ ์‹ ๋ถ„์„ ์„ค์ •ํ•˜๋Š” ํ•จ์ˆ˜๋ฅผ ์ •์˜ํ•ด์„œ ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง๊ณผ ๋ถ„๋ฆฌํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants