Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
:::note[Before you start]

- You can only remove one drive at a time using the GUI.
- Make sure your pool is using a redundant %%RAID|raid%% profile (like %%RAID 1|raid1%% for both data and metadata).
- The GUI currently only supports removing devices if your pool is set up for %%RAID 1|raid1%% (for both data and metadata for %%BTRFS|btrfs%%).
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistency with PR description and missing ZFS clarification.

The PR description states this change "notes that attempting disk removal via the GUI on pools using other redundant btrfs profiles will leave the pool degraded," but this warning is not present in the actual documentation. Additionally, while the note specifically mentions BTRFS, the rest of the document references both BTRFS and ZFS (lines 5, 14), but it's unclear whether the RAID 1 requirement also applies to ZFS pools or if ZFS has different requirements.

Consider:

  1. Adding the warning mentioned in the PR description about non-RAID 1 profiles leaving the pool degraded
  2. Clarifying whether the RAID 1 requirement applies to ZFS pools or if they have different support
💡 Suggested enhancement
-- The GUI currently only supports removing devices if your pool is set up for %%RAID 1|raid1%%  (for both data and metadata for %%BTRFS|btrfs%%).
+- The GUI currently only supports removing devices if your pool is set up for %%RAID 1|raid1%% (for both data and metadata for %%BTRFS|btrfs%%). Attempting to remove devices from %%BTRFS|btrfs%% pools using other redundant profiles via the GUI will leave the pool degraded.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- The GUI currently only supports removing devices if your pool is set up for %%RAID 1|raid1%% (for both data and metadata for %%BTRFS|btrfs%%).
- The GUI currently only supports removing devices if your pool is set up for %%RAID 1|raid1%% (for both data and metadata for %%BTRFS|btrfs%%). Attempting to remove devices from %%BTRFS|btrfs%% pools using other redundant profiles via the GUI will leave the pool degraded.
🤖 Prompt for AI Agents
In @docs/unraid-os/using-unraid-to/manage-storage/partials/remove-disk-gui.mdx
at line 4, Update the sentence that currently reads "The GUI currently only
supports removing devices if your pool is set up for %%RAID 1|raid1%% (for both
data and metadata for %%BTRFS|btrfs%%)" to (1) add the missing warning that
attempting disk removal via the GUI on pools using other redundant btrfs
profiles will leave the pool degraded, and (2) explicitly state the behavior for
ZFS pools (whether the RAID 1 requirement applies or if ZFS has different
support/limitations). Locate the sentence in remove-disk-gui.mdx and append a
clear warning sentence referencing non-RAID1 btrfs profiles leaving the pool
degraded, then add a short clarification line specifying the equivalent
requirement or difference for ZFS pools (e.g., "For ZFS, ...") so readers know
the exact support and risk.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Adding the warning mentioned in the PR description about non-RAID 1 profiles leaving the pool degraded
  • Clarifying whether the RAID 1 requirement applies to ZFS pools or if they have different support

I don't think this is needed, the section above this one already mentions btrfs and ZFS, and don't think we need to expand on the degraded issue, since it already says only raid1 is supported, but leave it up to @ljm42, please let me know if prefer that I change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

- To check your pool's %%RAID|raid%% level, navigate to the Main tab and click on the pool. Scroll down to the Balance Status section (for %%BTRFS|btrfs%%) or ZFS pool status (for %%ZFS|zfs%%).

:::
Expand Down
Loading