Skip to content

feat(docker): disable containers page file modification #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pujitm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(docker): disable containers page file modification #1870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions api/src/unraid-api/unraid-file-modifier/modifications/docker-containers-page.modification.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { readFile } from 'node:fs/promises';

import { ENABLE_NEXT_DOCKER_RELEASE } from '@app/environment.js';
import {
FileModification,
ShouldApplyWithReason,
Expand All @@ -12,28 +11,9 @@ export default class DockerContainersPageModification extends FileModification {
'/usr/local/emhttp/plugins/dynamix.docker.manager/DockerContainers.page';

async shouldApply(): Promise<ShouldApplyWithReason> {
const baseCheck = await super.shouldApply({ checkOsVersion: false });
if (!baseCheck.shouldApply) {
return baseCheck;
}

if (!ENABLE_NEXT_DOCKER_RELEASE) {
return {
shouldApply: false,
reason: 'ENABLE_NEXT_DOCKER_RELEASE is not enabled, so Docker overview table modification is not applied',
};
}

if (await this.isUnraidVersionGreaterThanOrEqualTo('7.3.0')) {
return {
shouldApply: true,
reason: 'Docker overview table WILL BE integrated in Unraid 7.3 or later. This modification is a temporary measure for testing.',
};
}

return {
shouldApply: false,
reason: 'Docker overview table modification is disabled for Unraid < 7.3',
reason: '',
};
}

Expand Down
Loading