Skip to content

Conversation

@kricsleo
Copy link
Member

resolves #680

@kricsleo kricsleo requested a review from pi0 as a code owner October 22, 2025 16:39
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are awesome!

@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.77%. Comparing base (a52bf75) to head (79b5e1f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #693   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files           5        5           
  Lines         401      401           
  Branches      126      126           
=======================================
  Hits          368      368           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Reconnect before dropping tables since the disposer will have
disconnected.
@43081j
Copy link
Member

43081j commented Dec 26, 2025

caught this up and fixed the tests FYI 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL database driver dispose doesn't close the connection

3 participants