Skip to content

fix: fix for loop local variable detection #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dword-design wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: fix for loop local variable detection #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
16941a7
fix: fix for loop local variable detection
dword-design Dec 13, 2025
a73ded0
fix: fix regex after minimal reproduction
dword-design Dec 16, 2025
471a7a2
chore: reset test
dword-design Dec 16, 2025
8774c3a
fix: add test
dword-design Dec 16, 2025
e43f828
chore: remove only
dword-design Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/regexp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const excludeRE = [
/\bclass\s*([\w$]+)\s*\{/g,
// defined as local variable
// eslint-disable-next-line regexp/no-super-linear-backtracking
/\b(?:const|let|var)\s+?(\[.*?\]|\{.*?\}|.+?)\s*?[=;\n]/gs,
/\b(?:const|let|var)\s+?(\[.*?\]|\{.*?\}|.+?)\s*?(?:=|;|\n|of)/gs,
]

export const importAsRE = /^.*\sas\s+/
Expand Down
6 changes: 6 additions & 0 deletions test/existing-scanning.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ describe('regex for extract local variable', () => {
{ input: 'const { ref} = Vue', output: ['ref'] },
{ input: 'const { maybe_test, $test} = Vue', output: ['maybe_test', '$test'] },
{ input: 'const [state] = useState(1)', output: ['state'] },
{ input: `
for (const [index] of [1,2,3].entries()) {
const a = AUTO_IMPORTED;
const b = []; // Make sure that the destructuring bracket in the loop does not expand to here
}
`, output: ['index', 'a', 'b'] },

// We may not able to handle these cases
// { input: 'const b = computed(0) , test=1;', output: ['b', 'test'] },
Expand Down