fix: resolve Phase 3 stress testing blockers #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses all 4 critical blockers identified during Phase 3 assessment: ## Blockers Fixed 1. **Integration tests enabled** (9 tests → 0 ignored) - Removed #[ignore] from gate_credits, gate_gradient, gate_election tests - All 13 integration tests now pass with --test-threads=1 2. **WebSocket-EnrBridge wiring** - Exposed EnrBridge from NetworkService as 4th tuple element - Wired all 5 ENR message handlers (gradient, election, candidacy, vote, credit) - Added proper error handling and local echo feedback 3. **TestCluster capacity expansion** - Increased node limit from 10 to 100 - Implemented hierarchical bootstrap topology for scale - Added 20-node cluster test (passes in ~7s) 4. **Partition simulator implementation** - Added PartitionSimulator with block_peer/unblock APIs - Integrated with NetworkService for message/connection filtering - Added TestCluster partition helpers (create_partition, heal_partition) - Feature-gated with `partition-testing` flag ## Test Results - 182 total tests, 178 passing (97.8%) - 0 failures, 4 doc-test ignores only - All integration tests enabled and passing ## Files Changed - 13 modified, 12 new files - ~4,400 lines added (code + documentation) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Run cargo fmt to fix formatting in: - enr_bridge/mod.rs - partition.rs - service.rs - tests/helpers/cluster.rs - tests/partition_test.rs - server/websocket.rs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The partition testing APIs (block_peer, unblock_peer, unblock_all_peers) are now always available rather than gated behind cfg flags. This fixes CI failures when running clippy with --no-default-features. These APIs are safe to expose unconditionally as they're only used for test infrastructure and don't affect production behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses all 4 critical blockers identified during Phase 3 assessment, preparing the codebase for multi-node stress testing.
Blockers Fixed
Changes
--test-threads=1partition-testingwith block/unblock APIsTest Results
Test plan
--test-threads=1🤖 Generated with Claude Code