Skip to content

Conversation

@anthonyronda
Copy link
Contributor

This is in response to a casually slipped-in error that caused one of our settings not to validate to the correct values in OSE 1.8.0

I don't think I have the right approach here, but I couldn't figure out how to cycle through Config.OSE.apply_damage_options and check each key-value against the setting's choices. Suggestions encouraged!

I'll get to the other settings after that

@anthonyronda
Copy link
Contributor Author

Note: these tests are no longer using the correct values, still looking for feedback on the approach here

@amir-arad
Copy link
Contributor

amir-arad commented Apr 9, 2023

This seems like a legit approach to validating that the settings are generated as expected.
However, if we simply hard-code the settings (as suggested in vttred/ose#393), instead of using elaborated expressions to generate them dynamically, there would be no need for such tests as they will mirror the settings code (and that's a testing antipattern)

so IMO this test is justified only for the encumbranceOption, at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants