Fix toast overlay blocking touches outside visible bounds#4
Open
mattisssa wants to merge 3 commits intounionst:mainfrom
Open
Fix toast overlay blocking touches outside visible bounds#4mattisssa wants to merge 3 commits intounionst:mainfrom
mattisssa wants to merge 3 commits intounionst:mainfrom
Conversation
The ScrollView used for swipe-to-dismiss was constrained in height but spanned the full screen width. PassThroughWindow only passes touches that land on the root view, so the full-width UIScrollView intercepted taps in the gutters beside the toast pill. Track contentWidth alongside contentHeight and apply both to the ScrollView frame so its hit area matches the visible toast content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The toast's scroll-to-dismiss
ScrollViewis constrained in height via.frame(height:)but spans the full screen width. SincePassThroughWindow.hitTestreturns any hit on a non-root subview, the full-widthUIScrollViewintercepts touches in the empty area to theleft and right of the toast pill — making that region non-interactive for the app underneath.
Fix
contentWidthinToastManageralongside the existingcontentHeightScrollViewframe so its hit area matches the visible toast contentVStackto full width so the now-narrowerScrollViewstays horizontally centered (GeometryReader defaults totop-leading alignment)