Open
Conversation
pingsutw
reviewed
Nov 4, 2025
| - "/dataplane/dask/v1/generated_name/task/{{`{{.executionProject}}`}}/{{`{{.executionDomain}}`}}/{{`{{.executionName}}`}}/{{`{{.nodeID}}`}}/{{`{{.taskRetryAttempt}}`}}/{{.Values.clusterName}}/{{`{{.namespace}}`}}/{{`{{.taskProject}}`}}/{{`{{.taskDomain}}`}}/{{`{{.taskID}}`}}/{{`{{.taskVersion}}`}}/{{`{{.generatedName}}`}}/status" | ||
| - displayName: Dask Runner logs | ||
| scheme: TaskExecution | ||
| templateUris: |
Contributor
There was a problem hiding this comment.
We don't need console link in v2, right?
Contributor
There was a problem hiding this comment.
Oh, so you mean even what's in here it's not actually used by V2?
https://github.com/unionai/cloud/blob/44be95e2f39200c72d6fb588f8aa9d9cad977196/deploy/dataplane/values-cluster-dask-aws.yaml#L17-L29
I thought, in APTCO case for example, that was being rendered for the log links
Contributor
There was a problem hiding this comment.
we don't need /console/projects/....., it's for v1
Collaborator
There was a problem hiding this comment.
@dansola Can you address this so we can merge this?
content/deployment/plugin-setup.md
Outdated
| - displayName: Ray Head logs | ||
| scheme: TaskExecution | ||
| templateUris: | ||
| - "/console/projects/{{`{{.executionProject}}`}}/domains/{{`{{.executionDomain}}`}}/executions/{{`{{.executionName}}`}}/nodeId/{{`{{.nodeID}}`}}/taskId/{{`{{.taskID}}`}}/attempt/{{`{{.taskRetryAttempt}}`}}/view/logs?duration=all&fromExecutionNav=true" |
Collaborator
There was a problem hiding this comment.
@dansola Can you address this so we can merge this?
Deploying docs with
|
| Latest commit: |
be94e38
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d4f96c7b.docs-dog.pages.dev |
| Branch Preview URL: | https://self-managed-plugins.docs-dog.pages.dev |
Collaborator
|
@dansola Just doing clean up and found this old PR. Do you want to complete it? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested internally on the union
arn:aws:eks:us-east-1:356633062068:cluster/oc-canary-daniel-byokcluster