Add podAnnotations support to executor deployment#306
Open
Conversation
Contributor
Current Aviator status
This PR is not ready to merge (currently in state pending): this PR has not been approved. Pending Status Checks
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
mhotan
force-pushed
the
mike/executor-pod-annotations
branch
from
32df451 to
55a82af
Compare
The executor (nodeexecutor) deployment was missing podAnnotations and global.podAnnotations support. The cacheservice, authz, and console controlplane templates were missing the global .Values.podAnnotations fallback. This enables operators to add annotations like prometheus.io/scrape for OTel collector discovery across all Union services. Verified via existing test values (added podAnnotations to dataplane.additional-podlabels.yaml and controlplane.aws.yaml). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mhotan
force-pushed
the
mike/executor-pod-annotations
branch
from
55a82af to
0b0b6b9
Compare
Contributor
Author
|
/aviator merge |
Contributor
|
Aviator has accepted the merge request. It will enter the queue when all of the required status checks have passed. Aviator will update the sticky status comment as the pull request moves through the queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
podAnnotationsandglobal.podAnnotationssupport, unlike all other dataplane deploymentsprometheus.io/scrape: "true"for OTel collector pod discoveryContext
Discovered during Apple integration — their Mosaic OTel collector uses
kubernetes_sd_configswithprometheus.io/scrapepod annotations for target discovery. All other DP deployments support this viaexecutor.podAnnotationsor the globaladditionalPodAnnotations, but the executor template was missed.Test plan
make generate-expected— snapshots regeneratedmake test— kubeconform passes🤖 Generated with Claude Code