Add additionalTemplates for cluster resource sync#304
Merged
Conversation
Customers overriding clusterresourcesync.templates to add custom per-project resources inadvertently replace the default namespace, service account, and resource quota templates — breaking project namespace creation. This adds an additionalTemplates list that is rendered alongside the defaults, giving a safe extension point. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
ctxswitch
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clusterresourcesync.additionalTemplatesas a safe extension point for customers to add custom per-project Kubernetes resourcesclusterresourcesync.templatesinadvertently replace the default namespace, service account, and resource quota templates — breaking project namespace creation (discovered debugging Apple's deployment)templatesoverrides continue to work as beforeTest plan
dataplane.additional-templates.yamlexercises both defaults + custom templatesdataplane.fully-selfhostedsnapshot is unchangedmake testpasses in CI🤖 Generated with Claude Code