ctx/feat(dataplane): add settable storage domain suffix for azure#303
Open
ctx/feat(dataplane): add settable storage domain suffix for azure#303
Conversation
Collaborator
ctxswitch
commented
Mar 24, 2026
- Added a new AZURE_STORAGE_DOMAIN_SUFFIX global to the dataplane Azure values with a default of core.windows.net. Wired it into both the stow domain_suffix config (which controls signed URL generation) and the metadataBucketPrefix (which controls internal ABFS paths), eliminating all hardcoded core.windows.net references.
- Updated the two Azure test values files to mirror the change and regenerated snapshots — all Azure tests pass.
- Users can now set global.AZURE_STORAGE_DOMAIN_SUFFIX to their custom domain to address Private Endpoint DNS issues.
Contributor
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
xjerod
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.