Draft
Conversation
Contributor
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
pmahindrakar-oss
approved these changes
Mar 24, 2026
Comment on lines
+139
to
+145
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: {{ template "flyte-pod-webhook.name" . }}-headless | ||
| namespace: {{ .Release.Namespace }} | ||
| labels: | ||
| {{- include "flytepropellerwebhook.labels" . | nindent 4 }} |
Contributor
There was a problem hiding this comment.
Shouldn't we see this in the generated test manifest files too
Contributor
Author
There was a problem hiding this comment.
Oh wow yeah, great catch thank you. updated
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
katrogan
force-pushed
the
secret-webhook-fanout
branch
from
289a0d1 to
2385d24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to work related to https://github.com/unionai/flyte/pull/935
I won't merge this until the corresponding Cloud changes are in, I've cut a new release and updated the appVersion and version in charts.