fix: correct bare-metal custom S3 dataplane values#255
Draft
mhotan wants to merge 1 commit intomike/baremetal-custom-s3-testfrom
Draft
fix: correct bare-metal custom S3 dataplane values#255mhotan wants to merge 1 commit intomike/baremetal-custom-s3-testfrom
mhotan wants to merge 1 commit intomike/baremetal-custom-s3-testfrom
Conversation
Fixes 6 issues found during deployment review of a bare-metal S3-compatible storage deployment: 1. Remove https:// from imageBuilder.defaultRepository 2. Add storage.region at top level to match stow region (RNO2A) 3. Remove container from storage.custom (eliminates duplicate YAML key) 4. Disable opencost (requires prometheus which is disabled) 5. Clear AWS IAM role annotations (not applicable to bare-metal) 6. Disable monitoring and cost (require prometheus) Generated manifest reduced from 2765 to 1754 lines. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 deployment issues found in the bare-metal custom S3 dataplane values test case (see draft PR #253 for the "before" state and review comments).
Fixes applied
imageBuilder.defaultRepositoryhas protocol prefixhttps://ghcr.io/acme-corp/acme/unionghcr.io/acme-corp/acme/unionstorage.regionnot set at top levelus-east-1region: RNO2Aaddedcontainer:key in rendered YAMLstorage.custom.containerduplicatesstorage.bucketNamecontainerfromstorage.customopencost.enabled: falseeks.amazonaws.com/role-arnon every SAuserRoleAnnotationKey: ""monitoring.enabled: false,cost.enabled: falseImpact
Generated manifest reduced from 2765 → 1754 lines (-1011 lines of unnecessary resources).
Not fixed (chart-level bug)
namespace_config.yamlinclusterresourcesync/configmap.yamldoesn't usetpl, causing backtick escapes to appear literally. This requires a chart template fix, not a values fix.Test plan
make generate-expectedpassesmake helm-testpassesbucketRegioncorrectly resolves toRNO2A🤖 Generated with Claude Code
main