Document Azure sovereign cloud DNS suffix configuration#242
Open
Document Azure sovereign cloud DNS suffix configuration#242
Conversation
Add guidance for configuring custom Azure Storage DNS suffixes needed for sovereign cloud deployments (Azure China, Azure Government). This covers three configuration touchpoints: storage.metadataPrefix, stow configDomainSuffix, and config.operator.clusterData.metadataBucketPrefix. Includes a new test case validating end-to-end rendering with a custom DNS suffix (dfs.core.chinacloudapi.cn). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
mhotan
commented
Feb 26, 2026
charts/dataplane/values.azure.yaml
Outdated
| # When set, this controls both rawoutput-prefix and metadataBucketPrefix. | ||
| # Default (Azure Public): "abfs://<container>@<account>.dfs.core.windows.net" | ||
| # Example for Azure China: | ||
| # metadataPrefix: "abfs://{{ .Values.global.METADATA_CONTAINER }}@{{ .Values.global.AZURE_STORAGE_ACCOUNT }}.dfs.core.chinacloudapi.cn" |
Contributor
Author
There was a problem hiding this comment.
I think we can do work here to make it so this config use {{ .Values.global.AZURE_STORAGE_DNS_SUFFIX }}. Potentially a missing tpl somewhere.
…FIX global Wire AZURE_STORAGE_DNS_SUFFIX through metadataPrefix, configDomainSuffix, and metadataBucketPrefix so users only change one value for sovereign clouds. Remove redundant azure-custom-storage-prefix test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
davidmirror-ops
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AZURE_STORAGE_DNS_SUFFIXfor configuring custom Azure Storage DNS suffixes needed for sovereign cloud deployments (Azure China, Azure Government)storage.metadataPrefix, stowconfigDomainSuffix, andconfig.operator.clusterData.metadataBucketPrefixdataplane.azure-custom-dns-suffix) validating end-to-end rendering withdfs.core.chinacloudapi.cnKey diff in generated output vs standard Azure test:
Test plan
make generate-expectedsucceedsmake testpasses (helm diff + kubeconform)tests/generated/dataplane.azure-custom-dns-suffix.yaml🤖 Generated with Claude Code