Add connect protocol, named ports, and legacyHosts to controlplane chart#236
Merged
Add connect protocol, named ports, and legacyHosts to controlplane chart#236
Conversation
Contributor
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
mhotan
force-pushed
the
mike/selfhosted-controlplane
branch
2 times, most recently
from
0f63396 to
adc5dca
Compare
This was referenced Feb 19, 2026
mhotan
force-pushed
the
mike/selfhosted-controlplane
branch
4 times, most recently
from
a8ab8ef to
0820357
Compare
3 tasks
mhotan
force-pushed
the
mike/selfhosted-controlplane
branch
2 times, most recently
from
f102b2b to
59e6b8b
Compare
mhotan
changed the title
- Add connectPort to sharedService config for services that support connect-rpc (authorizer, cluster, usage) - Fix _helpers.tpl to use toYaml for sharedService and sync helpers - Switch all service/ingress port references from numbers to named ports for clarity and connect protocol routing - Add named ports to cacheservice deployment - Update generated test fixtures Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Configure UNION_ORG as a legacy host in selfServeConfig so the LegacyOrgRewrite middleware rewrites org to "" on incoming requests. This fixes ENG26-237 where admin client wrapper unconditionally stamps org from identity context, but projects are seeded with org="". Safe for non-selfhosted deployments: SetSelfServeConfig skips empty strings, so legacyHosts: [''] is a no-op when UNION_ORG is unset. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update expected helm template output to reflect the selfServeConfig.legacyHosts addition to values.yaml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mhotan
force-pushed
the
mike/selfhosted-controlplane
branch
from
e45fc2e to
e1c98e2
Compare
ctxswitch
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foundation chart changes for self-hosted control plane deployments.
selfServeConfig.legacyHoststo basevalues.yaml(consolidated from per-cloud overlay files)The
legacyHostsconfig tellsLegacyOrgRewritemiddleware to rewrite org back to""for legacy hosts. BothSetSelfServeConfig()andsingleTenantOrgIDgracefully handle empty strings, so this is safe for non-selfhosted deployments whereUNION_ORGis empty.Test plan
helm templaterenders correctly with and withoutUNION_ORGsetmain