Consolidate namespace_mapping into single canonical Helm value#226
Merged
Consolidate namespace_mapping into single canonical Helm value#226
Conversation
Contributor
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
mhotan
force-pushed
the
mike/run-102-consolidate-namespace-mapping
branch
3 times, most recently
from
4675ee2 to
3b4025a
Compare
mhotan
force-pushed
the
mike/run-102-consolidate-namespace-mapping
branch
from
3b4025a to
39001de
Compare
mhotan
changed the base branch from
main
to
mike/disable-server-side-cluster-health-override
This was referenced Mar 3, 2026
3 tasks
katrogan
reviewed
Mar 4, 2026
| {{- end }} | ||
| {{- if and (not .Values.config.operator.org) .Values.namespace_mapping }} | ||
| org: | ||
| namespaceTemplate: {{ tpl (.Values.namespace_mapping.template | quote) $ }} |
Contributor
There was a problem hiding this comment.
sorry stupid question but wouldn't we still want this in the org block above when and (Values.config.operator.org) .Values.namespace_mapping
katrogan
approved these changes
Mar 4, 2026
mhotan
force-pushed
the
mike/run-102-consolidate-namespace-mapping
branch
from
6a83889 to
49a8b5b
Compare
mhotan
changed the base branch from
mike/disable-server-side-cluster-health-override
to
main
The top-level `namespace_mapping` in values.yaml was dead config (no template referenced `.Values.namespace_mapping`). Wire it as the canonical source of truth that cascades to all dataplane services when explicitly set: - clusterresourcesync: falls back to `.Values.namespace_mapping` when `.Values.config.namespace_mapping` is not set - nodeexecutor: auto-injects root-level `namespace_mapping` from the top-level value when `executor.raw_config.namespace_mapping` is not set - propeller: falls back to top-level value when `config.namespace_config` is not set - operator: falls back to top-level value for `org.namespaceTemplate` when `config.operator.org` is not set Default remains empty (no template). Per-service overrides still take precedence for backward compatibility. towards RUN-102 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add `namespace_mapping.template` to aws and fully-selfhosted test values to verify the canonical value cascades correctly to all service configmaps (clusterresourcesync, executor, propeller, operator). Azure test values already set per-service overrides (`config.namespace_config`, `config.operator.org`), which confirms backward compat (overrides take precedence over the top-level value). towards RUN-102 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mhotan
force-pushed
the
mike/run-102-consolidate-namespace-mapping
branch
from
49a8b5b to
c3b5c7d
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namespace_mappingvalue to the dataplane chart that cascades to all services that need it (propeller, clusterresourcesync, operator, executor)Context
Namespace mapping (the template that maps project-domain pairs to Kubernetes namespaces) was previously configured independently in each service's config section. This made it easy to misconfigure, as a mismatch between any two services causes silent runtime failures.
Related: ENG26-247 — consolidate namespace_mapping to a single location
Test plan
make helm-testpasses (golden files regenerated)namespace_mappingpropagates to all 4 configmaps{{ project }}-{{ domain }}when unsetRollout Plan
Non-breaking — existing per-service overrides still work. The new top-level value provides a single canonical location.
Rollback Plan
Revert this commit. Per-service configuration still works as before.
main