Document how to configure skipping private registries for serving enabled#204
Open
Document how to configure skipping private registries for serving enabled#204
Conversation
Contributor
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
pmahindrakar-oss
approved these changes
Jan 16, 2026
Comment on lines
+1414
to
+1421
| # Ref: https://knative.dev/docs/serving/configuration/deployment/#configure-deployment-resources | ||
| deployment: {} | ||
|
|
||
| # -- Knative Serving attempts to resolve image tags to digests within the Knative controller. | ||
| # This requires the Knative serving controller to have permissions to access the registry and resolve the tags. | ||
| # This configuration option allows you to disable this behavior and use the image tags directly without resolving them to digests. | ||
| # Example: | ||
| # registries-skipping-tag-resolving: "ghcr.io" |
Contributor
There was a problem hiding this comment.
Can we tie with this tag in the docs https://github.com/unionai/helm-charts/blob/main/charts/dataplane/values.yaml#L1403-L1405
The way you have in the test
# ----------------------------------------------------------------------------
# SECTION 8: Serving
# ----------------------------------------------------------------------------
serving:
enabled: true
extraConfig:
deployment:
registries-skipping-tag-resolving: "test.registry.com"
katrogan
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.