catalog/library/nginx: Add support for Nginx version 1.27.0#246
catalog/library/nginx: Add support for Nginx version 1.27.0#246amalia490 wants to merge 2 commits intounikraft:mainfrom
Conversation
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Why are there two directories? 1.27/ and 1.27-reverse-proxy/?
Also create a GitHub workflow file.
Be sure to use the correct version in README.md files.
Use the same commit syntax (with feat(examples): prefix) as in the existing commits in the repository.
amalia490
force-pushed
the
feat/nginx-1.27
branch
from
b408249 to
e0ebf4e
Compare
|
Thank you for the prompt feedback. I have implemented all requested changes and improvements, hope is everything ok now. |
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Have the PR only consist of two commits. One that adds the library/nginx/1.26 entry, and another one that adds the worklow.
Name the workflow file similar to others: library-nginx1.27.yaml.
amalia490
force-pushed
the
feat/nginx-1.27
branch
3 times, most recently
from
c4ac765 to
825799e
Compare
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
You have two commits with the same name?
Why are there two very similar .yaml files?
Use prefixes in front of all commit titles. Follow the convention of other commits in the commit history.
amalia490
force-pushed
the
feat/nginx-1.27
branch
from
8917895 to
6a83013
Compare
2 participants
This Pull Request integrates the latest stable Nginx version, v1.27.0, into the application catalog. The implementation involved creating a new version directory (1.27) based on the existing template, with the core change being the update of the source image tag within the Dockerfile (from 1.25.3 to 1.27.0). The application was successfully built for the qemu/x86_64 target and confirmed to be fully functional.