Skip to content

Comments

Add imagemagick to run.yaml#38

Open
kallui wants to merge 1 commit intounikraft:stagingfrom
kallui:stable
Open

Add imagemagick to run.yaml#38
kallui wants to merge 1 commit intounikraft:stagingfrom
kallui:stable

Conversation

@kallui
Copy link

@kallui kallui commented Sep 24, 2023

Added imagemagic app to elf-loader, and tested that its working

@razvand
Copy link
Contributor

razvand commented Sep 25, 2023

@kallui , you need to add a proper command, something that works, that does something. Update the command key accordingly. See the sample command used for nginx.

@razvand razvand self-requested a review September 25, 2023 00:23
@razvand razvand self-assigned this Sep 25, 2023
Signed-off-by: Nicholas Januar <nicho.januar@gmail.com>
@kallui
Copy link
Author

kallui commented Sep 25, 2023

@razvand Updated. thank you

@razvand razvand added the enhancement New feature or request label Sep 25, 2023
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

@razvand
Copy link
Contributor

razvand commented Sep 25, 2023

20 HP

@razvand razvand changed the base branch from stable to staging October 18, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants