Update following the removal of bootstrap.h in favor of libukpm#101
Open
mogasergiu wants to merge 3 commits intounikraft:stagingfrom
Open
Update following the removal of bootstrap.h in favor of libukpm#101mogasergiu wants to merge 3 commits intounikraft:stagingfrom
bootstrap.h in favor of libukpm#101mogasergiu wants to merge 3 commits intounikraft:stagingfrom
Conversation
Update implementation to use the libukpaging API. Signed-off-by: Michalis Pappas <michalis@unikraft.io>
The introduction of `libukpm` into the core obsoleted the `bootstrap.h` header and its related implementations, therefore, remove its inclusion from here as well. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
If the executable is not found in the environment, the `ret` variable is not updated to the correct error value and `realpath` has an invalid value which will cause an invalid page fault upon `free` attempt. Apply this check to `progname_conv` while at it as well, to be sure. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduction of
libukpminto the core obsoleted thebootstrap.hheader and its related implementations, therefore, remove its inclusion
from here as well.
Also, while at it, a small fixup for when the executable is not found in the path.
Depends-on: unikraft #1767