Skip to content

Another ICU property trying to sneak into Link_* property derivations #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eggrobin merged 2 commits into from
Dec 24, 2025
Merged

Another ICU property trying to sneak into Link_* property derivations #1267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a5f316
Markus’s review
eggrobin Dec 24, 2025
d105f43
Another ICU property trying to sneak into Link_* property derivations
eggrobin Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions unicodetools/data/linkification/dev/LinkBracket.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# LinkBracket.txt
# Date: 2025-12-24, 00:04:19 GMT
# Date: 2025-12-24, 14:27:07 GMT
# © 2025 Unicode®, Inc.
# Unicode and the Unicode Logo are registered trademarks of Unicode, Inc. in the U.S. and other countries.
# For terms of use and license, see https://www.unicode.org/terms_of_use.html
Expand Down Expand Up @@ -74,7 +74,7 @@
2E58 ; 2E57 #14.0 (⹘ ⇒ ⹗) RIGHT SQUARE BRACKET WITH DOUBLE STROKE
2E5A ; 2E59 #14.0 (⹚ ⇒ ⹙) TOP HALF RIGHT PARENTHESIS
2E5C ; 2E5B #14.0 (⹜ ⇒ ⹛) BOTTOM HALF RIGHT PARENTHESIS
2E63 ; 2E63 #18.0 (U+2E63 ⇒ U+2E63) RIGHT PARENTHESIS WITH MIDDLE RING
2E63 ; 2E62 #18.0 (U+2E63 ⇒ U+2E62) RIGHT PARENTHESIS WITH MIDDLE RING
3009 ; 3008 #1.1 (〉 ⇒ 〈) RIGHT ANGLE BRACKET
300B ; 300A #1.1 (》 ⇒ 《) RIGHT DOUBLE ANGLE BRACKET
300D ; 300C #1.1 (」 ⇒ 「) RIGHT CORNER BRACKET
Expand Down
9 changes: 6 additions & 3 deletions unicodetools/src/main/java/org/unicode/utilities/LinkUtilities.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import org.unicode.cldr.util.Counter;
import org.unicode.cldr.util.TransliteratorUtilities;
import org.unicode.props.IndexUnicodeProperties;
import org.unicode.props.UcdProperty;
import org.unicode.props.UcdPropertyValues.Idn_Status_Values;
import org.unicode.props.UnicodeProperty;
import org.unicode.props.UnicodeProperty.UnicodeMapProperty;
Expand Down Expand Up @@ -198,11 +199,11 @@ private LinkTermination(String uset) {

static final UnicodeSet EMAIL_EXCLUDES =
new UnicodeSet("[\\u0020 ; \\: \" ( ) \\[ \\] @ \\\\ < >]").freeze();
public static final UnicodeSet validEmailLocalPart =
static final UnicodeSet validEmailLocalPart =
new UnicodeSet(
"[\\p{XID_Continue}\\p{block=basic_latin}-\\p{Cc}]",
new ParsePosition(0),
VersionedSymbolTable.frozenAt(Settings.LATEST_VERSION_INFO))
VersionedSymbolTable.frozenAt(UNICODE_VERSION))
.removeAll(EMAIL_EXCLUDES)
.freeze();
public static final UnicodeProperty LinkEmail =
Expand All @@ -224,7 +225,9 @@ private static String quote(String s) {
}

private static int getOpening(int cp) {
return cp == '>' ? '<' : UCharacter.getBidiPairedBracket(cp);
return cp == '>'
? '<'
: IUP.getProperty(UcdProperty.Bidi_Paired_Bracket).getValue(cp).codePointAt(0);
}

private static UnicodeProperty LINK_PAIRED_OPENER;
Expand Down
Loading