Fix input poll compatibility #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original RPi.GPIO calls callback with channel number as parameter. Correctl callbacks list usage and pass channel number to callback. Fixes pibrella example.
Author
|
Fixes my test of pibrella siren on Fedora. |
Original C version allows repeated PWM.start() calls, because it just ignores start() call once helper thread is running. Emulate such behaviour and avoid printing warnings if already started. Fixes issue underground-software#53.
Contributor
|
Hi, thanks for the contribution. It looks like a good fix, but one of the tests (tests/test_gpio.py:test_add_event_detect_edge_conditions) seems to be running into some issues. I am looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original RPi.GPIO calls callback with channel number as parameter.
Correctl callbacks list usage and pass channel number to callback.
Fixes pibrella example.