Skip to content

fix: add encoding=utf-8 to CLI file operations #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightcityblade wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix: add encoding=utf-8 to CLI file operations #1807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crawl4ai/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ def get_global_config() -> dict:
config_dir.mkdir(parents=True, exist_ok=True)
return {}

with open(config_file) as f:
with open(config_file, encoding="utf-8") as f:
return yaml.safe_load(f) or {}

def save_global_config(config: dict):
config_file = Path.home() / ".crawl4ai" / "global.yml"
with open(config_file, "w") as f:
with open(config_file, "w", encoding="utf-8") as f:
yaml.dump(config, f)

def setup_llm_config() -> tuple[str, str]:
Expand Down Expand Up @@ -1235,20 +1235,20 @@ def crawl_cmd(url: str, browser_config: str, crawler_config: str, filter_config:
click.echo(main_result.markdown.fit_markdown)
else:
if output == "all":
with open(output_file, "w") as f:
with open(output_file, "w", encoding="utf-8") as f:
if isinstance(result, list):
output_data = [r.model_dump() for r in all_results]
f.write(json.dumps(output_data, indent=2))
else:
f.write(json.dumps(main_result.model_dump(), indent=2))
elif output == "json":
with open(output_file, "w") as f:
with open(output_file, "w", encoding="utf-8") as f:
f.write(main_result.extracted_content)
elif output in ["markdown", "md"]:
with open(output_file, "w") as f:
with open(output_file, "w", encoding="utf-8") as f:
f.write(main_result.markdown.raw_markdown)
elif output in ["markdown-fit", "md-fit"]:
with open(output_file, "w") as f:
with open(output_file, "w", encoding="utf-8") as f:
f.write(main_result.markdown.fit_markdown)

except Exception as e:
Expand Down