Remove cucumber #2694
Draft
Remove cucumber #2694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure we've ever caught actual errors this way and we haven't been adding new tests for any new features in several years: the only changes made have been to fix existing pages when the design changes.
EGiataganas
approved these changes
Nov 21, 2025
Member
There was a problem hiding this comment.
This doesn't have an equivalent system spec.
Perhaps worth just flagging what isn't already covered first and then we can drop cucumber
Contributor
Author
There was a problem hiding this comment.
There aren't actually that many feature tests anyway. I'll have a quick double check. It seems like it should actually be reasonably straightforward to convert them manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I'm not sure we've ever caught actual errors this way and we haven't been adding new tests for any new features in several years: the only changes made have been to fix existing pages when the design changes.