This repository was archived by the owner on Sep 13, 2024. It is now read-only.
Fix error when requesting files smaller than filesystem block size #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was very interested by this project but it wasn't working out of the box for me.
Firstly, here my system specs :
The issue is crashes during testing script and I wasn't able to read any file. (everything else seems ok).
After few debugging, I noticed that FUSE on my system always requests at least one block size of data (in my case, 4096 bytes).
If the file (or a file part, like the last one E.g.) was smaller than 4096, the server side doesn't understand and causes errors.
I fixed this by relying always on server filesystem metadata instead of what is requested by the client. In the PR, tests are ok and file reading is now working for me.