Skip to content

fix: 에디터에 텍스트량이 많을 때 높이가 늘어나는 문제 해결#146

Merged
nakyeonko3 merged 1 commit intomainfrom
fix/editor-overflow-
Jun 22, 2025
Merged

fix: 에디터에 텍스트량이 많을 때 높이가 늘어나는 문제 해결#146
nakyeonko3 merged 1 commit intomainfrom
fix/editor-overflow-

Conversation

@nakyeonko3
Copy link
Copy Markdown
Collaborator

@nakyeonko3 nakyeonko3 commented Jun 22, 2025

  • 부모 컴포넌트에 overflow-y-hidden 클래스를 추가하여 자식 컴포넌트가 높이를 늘리지 않도록 설정
  • 자식 컴포넌트인 에디터 컴포넌트에 overflow-y-auto 클래스를 추가하여 스크롤 가능하도록 유지

Summary by CodeRabbit

  • Style
    • 메모 생성 및 수정 모달에서 에디터 영역의 세로 스크롤바와 내용 넘침 현상이 방지되어 더욱 깔끔한 화면을 제공합니다.

- 부모 컴포넌트에 `overflow-y-hidden` 클래스를 추가하여 자식 컴포넌트가 높이를 늘리지 않도록 설정
- 자식 컴포넌트인 에디터 컴포넌트에 `overflow-y-auto` 클래스를 추가하여 스크롤 가능하도록 유지
@vercel
Copy link
Copy Markdown

vercel bot commented Jun 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
memoji ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2025 9:42am

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 22, 2025

Walkthrough

이 변경 사항은 MemoCreateModalMemoUpdateModal 컴포넌트에서 LexicalMarkdownEditor를 감싸는 컨테이너 <div>overflow-y-hidden CSS 클래스를 추가하여, 해당 영역에서 세로 스크롤이나 콘텐츠 오버플로우가 발생하지 않도록 수정한 것입니다. 다른 로직이나 이벤트 처리에는 변화가 없습니다.

Changes

파일(들) 변경 요약
src/components/memo-editor/MemoCreateModal.tsx,
src/components/memo-editor/MemoUpdateModal.tsx
LexicalMarkdownEditor를 감싸는 div에 overflow-y-hidden CSS 클래스 추가

Possibly related PRs

Suggested labels

bug

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-22T09_42_40_381Z-debug-0.log

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89631fa and 5581858.

📒 Files selected for processing (2)
  • src/components/memo-editor/MemoCreateModal.tsx (1 hunks)
  • src/components/memo-editor/MemoUpdateModal.tsx (1 hunks)
🔇 Additional comments (2)
src/components/memo-editor/MemoCreateModal.tsx (1)

78-78: 적절한 부모 컨테이너 오버플로우 처리
modal-mainoverflow-y-hidden을 추가하여 부모 요소가 자식 확장으로 인해 높이가 늘어나는 것을 방지한 것은 의도에 부합합니다.

src/components/memo-editor/MemoUpdateModal.tsx (1)

136-136: 적절한 부모 컨테이너 오버플로우 처리
modal-mainoverflow-y-hidden을 추가하여 모달 본문이 확장되지 않도록 한 것은 알맞은 접근입니다.

@nakyeonko3 nakyeonko3 merged commit 1acca4c into main Jun 22, 2025
5 checks passed
@nakyeonko3 nakyeonko3 deleted the fix/editor-overflow- branch June 22, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant