-
Notifications
You must be signed in to change notification settings - Fork 113
Fix build process #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix build process #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Arian-Ott I'll update this to resolve the merge conflicts here, too. |
`codecs.open()` is deprecated and throws a `DeprecationWarning`: ``` <string>:20: DeprecationWarning: codecs.open() is deprecated. Use open() instead. <string>:23: DeprecationWarning: codecs.open() is deprecated. Use open() instead. ```
The `tests_require` option throws a `UserWarning`: ``` /.../site-packages/setuptools/_distutils/dist.py:289: UserWarning: Unknown distribution option: 'tests_require' warnings.warn(msg) ```
This resolves build warnings thrown by setuptools:
```
/.../site-packages/setuptools/dist.py:759: SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!
********************************************************************************
Please consider removing the following classifiers in favor of a SPDX license expression:
License :: OSI Approved :: MIT License
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************
!!
```
Running `pip install -e.` displays the following deprecation warnings: ``` DEPRECATION: Legacy editable install of python-slugify==8.0.4 from file:///.../pr-python-slugify (setup.py develop) is deprecated. pip 25.3 will enforce this behaviour change. A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at pypa/pip#11457 ```
917e358 to
406c65b
Compare
Contributor
Author
|
@Arian-Ott Merge conflicts are fixed and the CHANGELOG has been updated with a summary. |
Collaborator
|
Thanks for your contribution, I'll look into it tomorrow and merge it. Have
already shut down the PC.
Also your git history is quite impressive. I wish more people were
contributing to open-source :D
…---
Arian
***@***.***
On Tue, 6 Jan 2026, 23:50 Kurt McKee, ***@***.***> wrote:
*kurtmckee* left a comment (un33k/python-slugify#159)
<#159 (comment)>
@Arian-Ott <https://github.com/Arian-Ott> Merge conflicts are fixed and
the CHANGELOG has been updated with a summary.
—
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVG4V3LJXVASA7K7ML35Q7T4FQ33DAVCNFSM6AAAAACIQXOCTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJWGY2DGMBXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for your work on python-slugify!
slugify's packaging is using a number of deprecated constructs, and building and installing the package throws a number of deprecation warnings. This PR resolves all of the warnings that I was seeing.
Remove deprecated
codecs.open()usagecodecs.open()is deprecated and throws aDeprecationWarning:Remove the unknown
tests_requireoptionThe
tests_requireoption throws aUserWarning:Resolve deprecated
Licensetrove classifier usageThis resolves build warnings thrown by setuptools:
Resolve deprecation warnings thrown when installing in editable mode
Running
pip install -e.displays the following deprecation warnings:With these changes, it's now possible to build and install the package without any warnings. Example:
Warning
Running commands like
python setup.py bdist_wheelis deprecated and may start failing at the end of this month. I strongly recommend migrating off of an executablesetup.pyfile entirely, in favor of a declarativepyproject.tomlfile.