Don't use getInObs() to get the number of observations for a storm#119
Open
ryanzomorrodi wants to merge 1 commit intoumr-amap:mainfrom
Open
Don't use getInObs() to get the number of observations for a storm#119ryanzomorrodi wants to merge 1 commit intoumr-amap:mainfrom
ryanzomorrodi wants to merge 1 commit intoumr-amap:mainfrom
Conversation
Contributor
|
Thanks for your PR @ryanzomorrodi . However, it's more a workaround than a real fix, as getInObs should be designed to do exactly this. |
Author
|
All good! I just thought if you are able to fix getInObs in a way that involves returns multiple storms then you still have the issue of knowing which storm is the one that you are referring to in the loop. But feel free to close the PR if its unneeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple fix for #118. I don't know how you all would want to handle multiple storm matches for
getInObs()so I didn't attempt to fix that.