Skip to content

Conversation

@99mini
Copy link
Member

@99mini 99mini commented Jun 30, 2025

#️⃣연관된 이슈

📝작업 내용

  • log와 try catch 수정합니다.

스크린샷 (선택)

💬리뷰 요구사항(선택)

@99mini 99mini self-assigned this Jun 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures the Android project for Kakao login support and refactors related login error handling.

  • Simplified signInWithKakao by merging token fetch and API call into one try block.
  • Wrapped loginWithOAuth in a try/catch to throw a CustomError on failure.
  • Updated Android Gradle build files to add the Kakao repository and correct plugin ordering.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/apis/auth/oauthHelper.ts Merged Kakao token acquisition into main try and removed early null-check.
src/apis/auth/client.ts Added try/catch around OAuth login and rethrows as CustomError.
android/build.gradle Added JitPack and Kakao Nexus Maven repositories.
android/app/build.gradle Moved com.google.gms.google-services plugin after dotenv apply.
Comments suppressed due to low confidence (1)

src/apis/auth/oauthHelper.ts:111

  • Add unit tests to cover the failure path when kakaoLogin() rejects or returns null, ensuring signInWithKakao returns null and displays the alert as expected.
    token = await kakaoLogin();

Copy link
Contributor

@l-lyun l-lyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 늦어 죄송합니다 감사합니다 👍

@99mini 99mini merged commit 2fb3cd7 into main Jul 9, 2025
1 check passed
@99mini 99mini deleted the chore/fix-android-kakao-login branch July 9, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants