Skip to content

Conversation

@99mini
Copy link
Member

@99mini 99mini commented Apr 15, 2025

#️⃣연관된 이슈

close: ummgoban/client-app#190

📝작업 내용

  • 회원 관련 프론트엔드 버그 사항 수정합니다.

스크린샷 (선택)

💬리뷰 요구사항(선택)

@99mini 99mini force-pushed the fix/signup-condition branch from 3045925 to f94cb22 Compare May 8, 2025 17:27
@99mini 99mini changed the title [WIP]fix: 회원가입 절차 핸들링 수정합니다. fix: 회원가입 절차 핸들링 수정합니다. May 15, 2025
@99mini 99mini marked this pull request as ready for review May 15, 2025 09:24
@99mini 99mini requested review from Copilot and l-lyun May 15, 2025 09:49
@99mini 99mini self-assigned this May 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes frontend issues during signup, including social login button rendering, enhanced form validations, and improved session/token handling.

  • Added documentation for token expiry in Session types
  • Updated social login button rendering and form validation logic
  • Improved query key invalidation, token refresh workflows, and error handling in API client

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/types/Session.ts Added JSDoc comments for token expiry fields to improve clarity.
src/screens/RegisterScreen/LoginScreen.tsx Uncommented SVG imports and modified platform checks for rendering social login buttons.
src/screens/RegisterMarketScreen/index.tsx Revised contact and business number validation logic.
src/hooks/useProfile.ts Changed options spreading to forward only onSettled callbacks in query configurations.
src/apis/orders/query.ts Updated query key with a timestamp and set refetchOnMount to 'always' for order queries.
src/apis/auth/client.ts Added refreshAccessToken function for handling token refresh operations.
src/apis/CustomError.ts Updated error messages to user-friendly localized text.
src/apis/ApiClient.ts Enhanced authorization header management and token refresh/error handling workflows.
Comments suppressed due to low confidence (8)

src/screens/RegisterScreen/LoginScreen.tsx:28

  • The rendering conditions for social login buttons appear inconsistent: the Kakao and Naver buttons are rendered unconditionally, while the Apple button is conditionally wrapped with Platform.OS. Consider applying a consistent platform check for all social login providers.
<CredentialLogin />

src/apis/ApiClient.ts:100

  • [nitpick] The handling for error code 400 is currently a placeholder. Consider implementing proper error handling or adding a TODO note to address it in a future update.
// 400 에러에 대한 추가 처리 필요 시 여기에 작성

src/screens/RegisterMarketScreen/index.tsx:97

  • [nitpick] The validation logic for contactNumber was refactored. Please verify that the new combined condition meets the intended business rules.
!(isLocalNumber(contactNumber) || isPhoneNumber(contactNumber))

src/screens/RegisterMarketScreen/index.tsx:98

  • [nitpick] A new check for businessNumber has been added. Confirm that this validation is consistent with the overall form requirements and does not conflict with other field validations.
!businessNumber

src/hooks/useProfile.ts:173

  • Replacing the spread of the full options object with options?.onSettled excludes other potential callbacks. Confirm that only onSettled should be forwarded to the mutation configuration.
...options?.onSettled,

src/hooks/useProfile.ts:210

  • Ensure that forwarding only the onSettled callback rather than the entire options object is the intended design for these mutations.
...options?.onSettled,

src/apis/orders/query.ts:7

  • Including Date.now() in the query key forces cache invalidation on every call, which may lead to unnecessary network requests. Verify that this behavior fits the application's requirements.
queryKey: ['orders', ordersStatus, marketId, Date.now()],

src/apis/orders/query.ts:15

  • Setting refetchOnMount to 'always' may result in excessive network traffic. Confirm that this configuration is necessary and aligned with intended data freshness levels.
refetchOnMount: 'always',

@99mini 99mini merged commit 7379aef into main May 15, 2025
1 check passed
@99mini 99mini deleted the fix/signup-condition branch May 15, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(frontend): 회원탈퇴 및 리프레쉬 토큰 문제 수정합니다

2 participants