updated the util code to buffer mode write #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianKs
reviewed
Apr 14, 2022
| def write_triple(f, buffer, ent, rel, t, S, P, O): | ||
| """Write a triple to a file. """ | ||
| f.write(str(ent[t[S]]) + "\t" + str(rel[t[P]]) + "\t" + str(ent[t[O]]) + "\n") | ||
| buffer += f"{str(ent[t[S]])}\t{str(rel[t[P]])}\t{str(ent[t[O]])}\n" |
Collaborator
There was a problem hiding this comment.
I think it is faster, to make the buffer a list of strings and finally join this list to a single string
buffer_list = []
buffer_list.append(new_triple_string)
buffer = ""
buffer.join(buffer_list)| f.write(str(ent[t[S]]) + "\t" + str(rel[t[P]]) + "\t" + str(ent[t[O]]) + "\n") | ||
| buffer += f"{str(ent[t[S]])}\t{str(rel[t[P]])}\t{str(ent[t[O]])}\n" | ||
| if len(buffer) > BUFFER_SIZE: | ||
| dump_buffer_to_file(buffer, f) |
Collaborator
There was a problem hiding this comment.
did you make sure, that the rest of the buffer is written to file at every necessary position? you did so in the RawSplit but process_triple is called also in other splits
Collaborator
|
Thanks, this is a good idea. Some small changes are needed though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the latest issue, I have tried to convert the write mode from line by line to a buffer mode write. I tried running the updated script on the toy dataset and the outputs are exactly same.