Remove redundant check of XDG_CONFIG_HOME#568
Open
couldbeanemail wants to merge 1 commit intoulyssa:mainfrom
Open
Remove redundant check of XDG_CONFIG_HOME#568couldbeanemail wants to merge 1 commit intoulyssa:mainfrom
couldbeanemail wants to merge 1 commit intoulyssa:mainfrom
Conversation
Contributor
|
|
Author
|
Afaik MacOS doesn't really support XDG_CONFIG_HOME. Thus it wouldn't
really be well defined to support it anyways. There seem to be other
mechanisms.
See:
dirs-dev/dirs-rs#56
dirs-dev/directories-rs#47 (comment)
In the case that one would want to pretend that XDG variables work
on other platforms, one should remove the call to dirs and make
this explicit.
best regards :)
|
Author
|
Also: the decision should be in line with what is decided in #557 or
vice versa.
I think the same logic would apply there, but I am aware that people
have different takes on this.
…On Mon, Feb 02, 2026 at 11:15:14PM +0100, ava wrote:
Afaik MacOS doesn't really support XDG_CONFIG_HOME. Thus it wouldn't
really be well defined to support it anyways. There seem to be other
mechanisms.
See:
dirs-dev/dirs-rs#56
dirs-dev/directories-rs#47 (comment)
In the case that one would want to pretend that XDG variables work
on other platforms, one should remove the call to dirs and make
this explicit.
best regards :)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking the config iamb checks XDG_CONFIG_HOME twice.
Once with the dirs dependency. Once on its own. This removes the redundant checks, and the now unused function.