Add ability to view info about a message#566
Draft
VAWVAW wants to merge 7 commits intoulyssa:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a a command
:messageto open an info screen that shows::openable linkshacks
I am using a readonly
modalkitTextBoxfor the display and added a hacky workaround to update the content without loosing cursor position and to add styling to the textbox.iamb/src/windows/room/message.rs
Lines 419 to 494 in 179648a
To implement this I had to use VAWVAW/modalkit@6bbe8a4 which sets a few struct member to
pub.I'm not sure whether it is worth to upstream this to modalkit completely or add a few wrappers to allow safe access to these members.