Open
Conversation
matrix_sdk::ClientBuilder.disable_ssl_verification() is mutually exclusive with setting our own http_client like we do: https://docs.rs/matrix-sdk/0.14.0/matrix_sdk/struct.ClientBuilder.html#example-for-using-a-custom-http-client therefore we reimplement it as per: https://github.com/matrix-org/matrix-rust-sdk/blob/2f7887d607e440609056a3a8da4dcabd01c0fe91/crates/matrix-sdk/src/http_client/native.rs#L189-L192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request adds a new
booleanconfiguration setting calledssl_verify, defaulting totrue.The name is inspired by
matrix_sdk::ClientBuilder.disable_ssl_verificationbut it removes the negation.Implementation-wise, unfortunately that method is mutually exclusive with setting our own
http_client(like we do):https://docs.rs/matrix-sdk/0.14.0/matrix_sdk/struct.ClientBuilder.html#example-for-using-a-custom-http-client
therefore we reimplement it as per:
https://github.com/matrix-org/matrix-rust-sdk/blob/2f7887d607e440609056a3a8da4dcabd01c0fe91/crates/matrix-sdk/src/http_client/native.rs#L189-L192
Last but not least: thank you for the excellent
iamb, I discovered it just a few days ago but it has already become my favourite matrix client!