Feat: Implement shell-completions using clap_complete#489
Open
titaniumtraveler wants to merge 2 commits intoulyssa:mainfrom
Open
Feat: Implement shell-completions using clap_complete#489titaniumtraveler wants to merge 2 commits intoulyssa:mainfrom
clap_complete#489titaniumtraveler wants to merge 2 commits intoulyssa:mainfrom
Conversation
|
Not a maintainer here, but IMO formatting changes should be separated out because they cause conflicts both for the PR itself (as is currently the case) and every other PR. |
Author
Hmm, fair. I might just discard them and rebase the Really just opened the PR because the missing completions annoyed my during setup lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know having shell-completions on
iambis kinda silly considering the CLIliterally just contains
--config-directoryand--profile(and the shortvariants), but at this point I am just too used to having them everywhere.
Usually I would also have put it into a
completionssubcommand, but wasn't sure if that is useful considering that there aren't any other subcommands there at the moment.When dynamic completions get stabilized in
clap, they could probably also beused to complete available profiles and such.
About the
cargo fmt-commit: There might be some breackage with the formatting?fn_call_widthbeing set anything seems to preventrustfmtfrom running atall.
So I commented that part out and
cargo +nightly fmt --alled the repo.Wasn't sure if it opening a separate PR for that was worth it.
But am totally happy to do that if wanted.