Open
Conversation
22fa520 to
ab304a0
Compare
Contributor
@VAWVAW do you mean these were bugs that are fixed, or these are new issues in this PR? |
Contributor
Author
|
I just did some more testing and it looks like both are bugs that are in the |
ab304a0 to
3a921ce
Compare
3a921ce to
d713278
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Profiling the startup of iamb in
footusingflamegraph, I noticed that most of the cpu time was spent rendering image previews. This PR changes the rendering to be in the background (not blocking ui responsiveness) and lazily (on message rendering).I had some bugs if the last message is an image:
Profiling data
before optimizations:



with lazily computed sixel preview:
and lazily decoded jpg: