Some improvements to automatically toggling room focus#439
Open
VAWVAW wants to merge 2 commits intoulyssa:mainfrom
Open
Some improvements to automatically toggling room focus#439VAWVAW wants to merge 2 commits intoulyssa:mainfrom
VAWVAW wants to merge 2 commits intoulyssa:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are somewhat opinionated so feel free to change them.
The first commit makes it so that changing to insert mode while a message is marked will reply to that message instead of creating a completely new message. This will only happen if you are not currently drafting a message.
The second commit changes the behavior when you move down in the message buffer. Before it would just ignore it but now it will move to scrollback if there is a message under the selected one. This feels more natural to me since there is a highlighted message in the scrollback and I would assume that a down action would move that focus.