This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Build custom error manager #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSz50
force-pushed
the
build-custom-error-manager
branch
from
1fcfa9f to
070d26f
Compare
amwolff
reviewed
May 4, 2020
Contributor
amwolff
left a comment
amwolff
left a comment
There was a problem hiding this comment.
I'm not sure about the convention for errors, but it looks simple enough.
I suggest to rename database package to something like db and errors to something else also. This way we won't be shadowing already existing packages from the standard library.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.