Release publish #58
Merged
Release publish #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2025 08:24
Author
|
Just FYI, I still don't think I can review my own code in order to merge my own request. I prefer reviews, but having the option would be nice in case of emergency fixes/absences. |
nrsa222
requested review from
a team
and removed request for
a team and
nrsa222
Author
|
A lot of the activity above was shuffling while we figured out branch protection rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duplicate action firing. Before, CI was running on every push in the PR, and then again after the PR was merged. Since every commit will be tested during PR, we only need the event during PRs.
Fixes publish event not firing. Before, the publish event would not fire after CI. Now it should fire on all pushes to dev, which as of 11/5 has branch protection. That push includes when a merge request is completed.