Create tests for ukf meta#211 #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stskjisc
force-pushed
the
123-create-tests-for-ukf-meta#211
branch
from
ab0be83 to
9f8dce2
Compare
Collaborator
Author
All tests look good
|
stskjisc
force-pushed
the
123-create-tests-for-ukf-meta#211
branch
2 times, most recently
from
c833cbe to
dfdc6fd
Compare
Member
|
Hi @stskjisc , how far did this get in ukf-meta. Did it get landed? If so, I guess we can update the testbed and then remove the development overlay from the commit. |
Member
|
It is not, sorry. I will look at ukf-meta now. |
Member
|
Looking at ukf-meta, I think at some point you will want to add tests that exercise the new regexp fragment |
stskjisc
force-pushed
the
123-create-tests-for-ukf-meta#211
branch
from
dfdc6fd to
c417fb4
Compare
Collaborator
Author
|
The ukf-meta changes have been landed on Aug26, it is safe to merge this change |
stskjisc
force-pushed
the
123-create-tests-for-ukf-meta#211
branch
from
c417fb4 to
258e974
Compare
philsmart
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new check
Add good tests for mdui:GeolocationHint format check
Add bad tests for mdui:GeolocationHint format check