Skip to content

Conversation

@ukeSJTU
Copy link
Owner

@ukeSJTU ukeSJTU commented Jan 20, 2026

描述

解决了 #276 中更新的包名导致本地相对路径导入出错的问题。

相关问题

变更类型

  • Bug 修复(不会破坏现有功能的非破坏性变更)
  • 新功能(添加功能的非破坏性变更)
  • 破坏性变更(会导致现有功能无法正常工作的修复或功能)
  • 文档更新
  • 性能改进
  • 代码重构
  • CI/CD 改进

测试

  • 我已经在本地测试了这些更改
  • 我已经添加了证明我的修复有效或我的功能工作的测试
  • 新的和现有的单元测试在我的更改下都能通过
  • 我已经检查了代码能够无错误地构建

截图(如果适用)

检查清单

  • 我的代码遵循此项目的代码风格
  • 我已经对自己的代码进行了自我审查
  • 我已经对代码进行了注释,特别是在难以理解的地方
  • 我已经对文档进行了相应的更改
  • 我的更改没有产生新的警告
  • 我已经添加了证明我的修复有效或我的功能工作的测试
  • 新的和现有的单元测试在我的更改下都能通过

代码审查检查清单(供审查者使用)

  • 代码可读且有良好的文档
  • 更改经过了适当的测试
  • 没有明显的性能问题
  • 已解决安全考虑
  • 破坏性变更已得到适当记录

附加说明

#276 的 Build Check 通过的原因是 pnpm-lock.yaml 文件没有变化,因此 resolution step is skipped,进而没有检查出这个问题。

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ukeSJTU, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a misconfiguration issue within the local monorepo by standardizing the naming of the shared UI package. The change involves updating the package identifier and all its references across various applications and configuration files, ensuring consistent module resolution and improving overall project maintainability.

Highlights

  • UI Package Renaming: The shared UI package has been renamed from @nomad/ui to @ukesjtu/nomad-ui to address a misconfiguration in the local monorepo setup.
  • Configuration Updates: All relevant configuration files, including package.json, next.config.ts, tsconfig.json, and Storybook/Vitest configurations, have been updated to reflect the new package name.
  • Import Path Adjustments: Numerous component and utility import paths across apps/demo, apps/storybook, and apps/web have been modified to correctly reference the newly named UI package.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 旨在修复因包名 @nomad/ui 更新为 @ukesjtu/nomad-ui 导致的本地 monorepo 导入错误问题。您对整个代码库进行了全面的包名替换,涵盖了 TypeScript 配置文件、package.json 依赖、导入语句、文档以及测试文件中的 mock。

整体来看,这是一次彻底且一致的重构,有效地解决了问题。此外,许多文件中的导入顺序和代码格式也得到了优化,提高了代码的可读性。

代码变更没有发现明显的问题,做得很好!

@ukeSJTU ukeSJTU temporarily deployed to github-pages-preview January 20, 2026 10:32 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

🗑️ Preview Deployment Cleaned Up

The preview deployment for this PR has been removed from GitHub Pages.

@ukeSJTU ukeSJTU merged commit f260851 into develop Jan 20, 2026
15 checks passed
@ukeSJTU ukeSJTU deleted the fix/monorepo-deps branch January 20, 2026 11:50
github-actions bot added a commit that referenced this pull request Jan 20, 2026
github-actions bot added a commit that referenced this pull request Jan 20, 2026
…es/ui for local monorepo (#277)

* fix: resolve shared ui package naming issue

* fix: update all internal usage of nomad ui to new domain

* fix: update types in tsconfig for testing libraries f260851
github-actions bot added a commit that referenced this pull request Jan 20, 2026
* fix: resolve shared ui package naming issue

* fix: update all internal usage of nomad ui to new domain

* fix: update types in tsconfig for testing libraries f260851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants