Skip to content

Conversation

@clmould
Copy link
Collaborator

@clmould clmould commented Dec 12, 2025

Description

Closes #3998
Before, the message printing if a variable was below its lower bounds it was using the scaled_upper_bounds array so the message was wrong in some cases before:

ixc = 18
boundl(18) = 3.0
boundu(18) = 4.0
q95 = 3.0

* TF Current per turn [A]
ixc = 60
boundl(60) = 65000.0
boundu(60) = 90000.0
c_tf_turn = 65000.0
image

Now it prints correctly:
image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Dec 12, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.89%. Comparing base (25480ae) to head (0878fca).

Files with missing lines Patch % Lines
process/scan.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4007      +/-   ##
==========================================
- Coverage   45.89%   45.89%   -0.01%     
==========================================
  Files         123      123              
  Lines       29064    29066       +2     
==========================================
  Hits        13340    13340              
- Misses      15724    15726       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould requested a review from mkovari December 12, 2025 10:06
@clmould clmould merged commit 0548fed into main Dec 12, 2025
18 checks passed
@clmould clmould deleted the 3998-bugbug-reporting-when-an-operating-limit-has-been-reached branch December 12, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛Bug reporting when an operating limit has been reached

4 participants