-
Notifications
You must be signed in to change notification settings - Fork 17
♻️ Create outboard blanket class #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn calculated values for coolant pumping powers
…d OutboardBlanket
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3997 +/- ##
==========================================
- Coverage 46.03% 43.56% -2.48%
==========================================
Files 123 123
Lines 28964 30818 +1854
==========================================
+ Hits 13335 13427 +92
- Misses 15629 17391 +1762 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
requested changes
Dec 5, 2025
timothy-nunn
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the blanket geometry and pumping power calculation logic in the blanket library and its users. The main improvements are the introduction of dedicated
InboardBlanketandOutboardBlanketclasses with clearer geometry calculation methods, and the refactoring of the pumping power calculation into a function with explicit arguments and return values. These changes increase modularity, clarity, and maintainability of the code, especially for the DCLL and HCPB blanket models.Refactoring and modularization of blanket geometry:
InboardBlanketandOutboardBlanketclasses inblanket_library.py, each encapsulating their respective geometry calculations, and updated DCLL and HCPB blanket models to inherit from these classes instead of the genericBlanketLibrary(process/blanket_library.py,process/dcll.py,process/hcpb.py). [1] [2] [3] [4] [5]set_blanket_inboard_module_geometry,set_blanket_outboard_module_geometry) and updated their usage in DCLL and HCPBrunmethods (process/blanket_library.py,process/dcll.py,process/hcpb.py). [1] [2] [3]set_blanket_module_geometry, delegating this responsibility to the new methods and the respective blanket classes (process/blanket_library.py).Refactoring of pumping power calculation:
set_pumping_powers_as_fractionsfrom a state-mutating function to a pure function with explicit arguments and return values, improving clarity and testability. Updated all usages to unpack the returned tuple and assign the results (process/blanket_library.py,process/dcll.py,process/hcpb.py). [1] [2] [3]Code cleanup and logic improvements:
process/blanket_library.py).These changes collectively make the codebase more modular, easier to extend for new blanket types, and clearer in terms of data flow and responsibility separation.## Description
Checklist
I confirm that I have completed the following checks: