-
Notifications
You must be signed in to change notification settings - Fork 17
🎨 Plot proc radiation contour plot #3996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
==========================================
- Coverage 46.03% 42.63% -3.41%
==========================================
Files 123 123
Lines 28964 32455 +3491
==========================================
+ Hits 13335 13837 +502
- Misses 15629 18618 +2989 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f11588c to
d44aaca
Compare
d44aaca to
ed03f98
Compare
jonmaddock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the plotting calculations quite hard to follow, especially when double or triple-indexing arrays: please add some comments. I don't understand the profile calculations like you do, but do you have a docs reference for:
ne = nd_plasma_electron_on_axis * (1 - rho**2) ** alphan
?
25df405 to
68ec297
Compare
This pull request enhances the plasma radiation plotting functionality by introducing a new 2D contour plot for radiation density and refactoring the profile generation logic for improved clarity and consistency. The main updates include the addition of the
plot_rad_contourfunction, adjustments to how plasma profiles are constructed, and integration of the new contour plot into the main plotting workflow, with appropriate handling for unsupported plasma shapes.Major changes:
1. New Feature: 2D Radiation Contour Plot
plot_rad_contourfunction to generate 2D contour plots of radiation density using plasma profile and impurity data, including mirrored plotting for both plasma halves and enhanced plot formatting.main_plot), displaying it when the plasma shape supports closed boundaries, and providing a user-friendly message when not supported.2. Plasma Profile Calculation Refactor
plot_radprofileto ensure consistent use of then_plasma_profile_elementsparameter and to clarify the logic for both non-pedestal and pedestal cases. [1] [2]3. Bug Fixes and Consistency Improvements
min(0.9999, ...)calls, ensuring correct profile behaviour near the plasma edge.Checklist
I confirm that I have completed the following checks: